A few points to note on this, as it's a subject we've looked at a bit recently:
— The App Store license agreement warns users that certain info about them may be uploaded etc.
— The vast majority of this data – usually collected for (IMO) perfectly valid analytics reasons – is 'anonymized', which I think roughly means pooled together in such a way that one individual's data cannot be traced back to them.
— If you bought software from ModMyiFone, you likely bought a jailbreak app – in which case you can't really blame Apple for anything the app is doing – as they do not authorize jailbreak and in fact consider it 'illegal'.
— If you are jailbroken there is an app called PrivaCy – that lets you exert some control over data collected by apps on your iPhone.